added integration test shutdown for bluechi #657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
engelmi
force-pushed
the
integration-tests-shutdown
branch
from
360960c to
faf963a
Compare
Relates to: eclipse-bluechi#397 In order to finalize all data - journal and valgrind logs and code coverage files - a shutdown step has been introduced that stops the bluechi components in all container. Also, error logs have been added in the run routine that should help debugging test failures. Signed-off-by: Michael Engel <[email protected]>
engelmi
force-pushed
the
integration-tests-shutdown
branch
from
faf963a to
eec9224
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to finalize all data - journal and valgrind logs and code coverage files - a shutdown step has been introduced that stops the bluechi components in all container.
Also, error logs have been added in the run routine that should help debugging test failures.
/cc @ArtiomDivak
Without stopping the systemd service(s), the
.gcdafiles aren't written so that the coverage collection can't find them and fails. This PR with the shutdown before collecting artifacts should ensure that the.gcdafiles are written and finalized.Relates to: #397