log error when at least one list units request fails #649
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to:
#567
#568
When list units for all nodes is run and the requests are submitted, it might happen that one of those is failing. Previously, this led to a failure when reading the message for the node where the request failed - which got propagated to the caller.
Now, an additional error log in BlueChi is made and the error code is extracted from the sd_bus_message.
One option to reproduce this is by registering a
bluechi-agent
, but not providing thelist units
method.Previous error message with
bluechictl
:New message:
Not sure this is better for the client, but
sd_bus_message_get_errno
retrieves error code 53 (Invalid request descriptor). The log inbluechi-controller
provides more info: