re-enable proxy service fails on execstart integration test #627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
engelmi
force-pushed
the
reenable-proxy-service-fails-on-execstart-test
branch
2 times, most recently
from
28c9d13 to
00fa431
Compare
mwperina
reviewed
Nov 1, 2023
mwperina
reviewed
Nov 1, 2023
tests/tests/tier0/proxy-service-fails-on-execstart/test_proxy_service_fails_on_execstart.py
Outdated
Show resolved
Hide resolved
engelmi
force-pushed
the
reenable-proxy-service-fails-on-execstart-test
branch
3 times, most recently
from
8aee893 to
6849584
Compare
alexlarsson
reviewed
Nov 3, 2023
|
Actually, I wonder if this is the right approach.
|
|
Another option is to add the kill signal to SuccessExitStatus= |
engelmi
force-pushed
the
reenable-proxy-service-fails-on-execstart-test
branch
2 times, most recently
from
34effde to
c8e960c
Compare
alexlarsson
reviewed
Nov 6, 2023
engelmi
force-pushed
the
reenable-proxy-service-fails-on-execstart-test
branch
from
c8e960c to
a3dc382
Compare
Signed-off-by: Michael Engel <[email protected]>
By using ExecStop= instead of ExecStart= a race condition is avoided that leads systemd to send a SIGTERM signal to the dep service, resulting in it being in a failed state. Signed-off-by: Michael Engel <[email protected]>
engelmi
force-pushed
the
reenable-proxy-service-fails-on-execstart-test
branch
from
a3dc382 to
987d0bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #320
This PR re-enables the - currently - skipped integration test for the proxy service where the
ExecStartreturns exit code 1.Running it locally a few times it works fine, so lets enable it again and see if the flakiness is gone.