fix invalid read on disconnecting anonymous node #592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: eclipse-bluechi#591 When an anonymous node has been disconnected in the controller and the cleanup has been done, a log statement was made afterwards. This statement differed based on the node name. Since the node instance has been cleaned up (freed), but not set to NULL, valgrind reported this as an invalid read. Moved the log statements accordingly. Signed-off-by: Michael Engel <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #591
When an anonymous node has been disconnected in the controller and the cleanup has been done, a log statement was made afterwards. This statement differed based on the node name. Since the node instance has been cleaned up (freed), but not set to NULL, valgrind reported this as an invalid read. Moved the log statements accordingly.