Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added integration test for wildcard subscription with reconnecting node #505

Merged
merged 1 commit into from
Aug 25, 2023

Conversation

engelmi
Copy link
Member

@engelmi engelmi commented Aug 25, 2023

Fixes: #420
Relates to: #414

This PR adds an integration test that verifies that the proper virtual unit_new and unit_removed signals are emitted to a monitor when a node disconnects and reconnects again.

Fixes: #420
Adds an integration test that verifies that the proper
virtual unit_new and unit_removed signals are emitted
to a monitor when a node disconnects and reconnects
again.

Signed-off-by: Michael Engel <[email protected]>
Copy link
Member

@mwperina mwperina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@engelmi engelmi merged commit 6a68553 into main Aug 25, 2023
@engelmi engelmi deleted the add-monitor-wildcard-node-reconnect-test branch August 25, 2023 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add integration tests: node disconnects/reconnects while unit monitor is active
2 participants