integration tests: invalid bluechi agent port

[dougsland]

This test includes three nodes: bluechi-controller, node-foo, node-bar.

• bluechi-controller is the controller node
• node-foo will start the agent service with normal configuration using port 8420
• node-bar will try to start the agent service with incorrect port (842O) and should fail (as expected)

Related: #416

Signed-off-by: Douglas Schilling Landgraf [email protected]

[dougsland]

I will send more patches to complete #416. One test per file to simplify the code/review/test. We should cover all agent/controller options.

[dougsland]

Funny to see that even with invalid configuration GitHub Actions is "able to start" (result 0):

From the failure logs:

14:11:07                 out:         result, _ = nodes[NODE_BAR].exec_run('systemctl restart bluechi-agent')
14:11:07                 out: >       assert result == 1
14:11:07                 out: E       assert 0 == 1

[dougsland]

Testing locally the new validation:

OS:

# cat /etc/redhat-release
CentOS Stream release 9

Running with tmt:

#control> echo "tier: 1" >> tests/tests/tier0/bluechi-agent-invalid-port-configuration/main.fmf
#control> tmt run test --filter tier:1
/var/tmp/tmt/run-001

/plans/tier0
    discover
        how: fmf
        directory: /root/invalidconfig/bluechi/invalidconfig/bluechi/tests
        filter: tier:1
        summary: 1 test selected
    provision
        how: local
        multihost name: default-0
        arch: x86_64
        distro: CentOS Stream 9
        summary: 1 guest provisioned
    prepare
        queued push task #1: push on default-0

        push task #1: push on default-0

        queued prepare task #1: Set containers setup on default-0

        prepare task #1: Set containers setup on default-0
        how: shell
        name: Set containers setup
        overview: 1 script found

        queued pull task #1: pull on default-0

        pull task #1: pull on default-0

        summary: 1 preparation applied
    execute
        queued execute task #1: default-0 on default-0

        execute task #1: default-0 on default-0
        how: tmt
        progress:
        summary: 1 test executed
    report
        how: junit
        output: /var/tmp/tmt/run-001/plans/tier0/report/default-0/junit.xml
        summary: 1 test passed
    finish

        summary: 0 tasks completed

total: 1 test passed

[dougsland]

changing the approach to using the output string from systemctl status bluechi-agent still do NOT make GitHub Actions happy. 😖 Locally it just works as checking the return from shell. /me thinking....

out: test_agent_invalid_port_configuration.py:23: Exception
18:19:20                 out: =========================== short test summary info ============================
18:19:20                 out: FAILED test_agent_invalid_port_configuration.py::test_agent_invalid_port_configuration - Exception: bluechi-agent should FAILED during the restart but DO NOT FAILED
18:19:20                 out: ============================== 1 failed in 3.35s ===============================

[dougsland]

okay, found that during the tmt tests in Github Actions systemd was trying to restart the service and the output of systemctl status bluechi-agent was "activating" but we had a failure count = 1. Updated the test, green light to review and merge if accepted.

Locally also pass:

# tmt run test --filter tier:1
/var/tmp/tmt/run-014

/plans/tier0
    discover
        how: fmf
        directory: /root/final/bluechi/tests
        filter: tier:1
        summary: 1 test selected
    provision
        how: local
        multihost name: default-0
        arch: x86_64
        distro: CentOS Stream 9
        summary: 1 guest provisioned
    prepare
        queued push task #1: push on default-0

        push task #1: push on default-0

        queued prepare task #1: Set containers setup on default-0

        prepare task #1: Set containers setup on default-0
        how: shell
        name: Set containers setup
        overview: 1 script found

        queued pull task #1: pull on default-0

        pull task #1: pull on default-0

        summary: 1 preparation applied
    execute
        queued execute task #1: default-0 on default-0

        execute task #1: default-0 on default-0
        how: tmt
        progress:
        summary: 1 test executed
    report
        how: junit
        output: /var/tmp/tmt/run-014/plans/tier0/report/default-0/junit.xml
        summary: 1 test passed
    finish

        summary: 0 tasks completed

total: 1 test passed

[engelmi]

A few NITs, but otherwise looks great!

[engelmi]

LGTM

[dougsland]

LGTM

Thanks for the comments, let's make it fly! One more test integration added \o/