Prevent continuous heartbeats #395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
engelmi
requested review from
alexlarsson,
mkemel,
rhatdan and
sdunnagan
as code owners
mwperina
reviewed
Jul 26, 2023
If the heartbeat interval is set to 0, this event gets fired continuously, consuming a lot of CPU. To prevent this don't register any heartbeat for interval values smaller than or equal to 0. Smaller values also disable the heartbeat, so not registering at all has the same result Signed-off-by: Michael Engel <[email protected]>
Signed-off-by: Michael Engel <[email protected]>
engelmi
force-pushed
the
prevent-continuous-heartbeats
branch
from
a1d9260 to
30cf543
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
disables heartbeat for intervals smaller or equal to 0
If the heartbeat interval is set to 0, this event gets fired continuously, consuming a lot of CPU (on my machine ~80% for hirte-agent and ~60% for hirte). To prevent this don't register any heartbeat for interval values smaller than or equal to 0. Smaller values also disable the heartbeat, so not registering at all has the same result.
fully initializes the serveraddr struct
Running hirte with valgrind, it complains about
servaddr.sin6_flowinfoandsin6_scope_idnot to be initialized. Setting these values to 0 should keep the current behavior and still initialize it.