added typecast to uintptr_t for subscription pointer #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
engelmi
requested review from
alexlarsson,
mkemel,
rhatdan and
sdunnagan
as code owners
|
I'd like to verify that this really fixes the issue in https://koji.fedoraproject.org/koji/taskinfo?taskID=101972333 before merging. Is there a way to build this PR in koji.fedoraproject.org? |
Signed-off-by: Michael Engel <[email protected]>
engelmi
force-pushed
the
fix-pointer-to-int-conversion-in-hashmap-hash
branch
from
e84e42f to
c29b425
Compare
|
@engelmi LGTM can we merge? |
I'll do a scratch build and report if that doesn't fix it :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to fix a pointer to int cast error due to different size on 32-bit platforms. Occurred in:
https://koji.fedoraproject.org/koji/taskinfo?taskID=101972333
It uses the uintptr_t data type to first "safely" cast the pointer address to an int and then casts it to an
uint64_t(as required by the hashmap library).