Set Log Level API #347
Merged
Set Log Level API #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArtiomDivak
requested review from
alexlarsson,
engelmi,
mkemel,
rhatdan and
sdunnagan
as code owners
mwperina
previously requested changes
Jun 12, 2023
ArtiomDivak
force-pushed
the
issue-189
branch
9 times, most recently
from
d222483 to
67b96b4
Compare
mwperina
reviewed
Jun 14, 2023
ArtiomDivak
force-pushed
the
issue-189
branch
2 times, most recently
from
9258008 to
b6c21fe
Compare
mwperina
reviewed
Jun 14, 2023
mwperina
reviewed
Jun 14, 2023
ArtiomDivak
force-pushed
the
issue-189
branch
4 times, most recently
from
ea2da31 to
193af4a
Compare
mkemel
reviewed
Jun 20, 2023
engelmi
reviewed
Jun 22, 2023
engelmi
reviewed
Jun 22, 2023
engelmi
reviewed
Jun 22, 2023
engelmi
reviewed
Jun 22, 2023
engelmi
reviewed
Jun 22, 2023
engelmi
reviewed
Jun 22, 2023
engelmi
reviewed
Jun 22, 2023
engelmi
reviewed
Jun 22, 2023
engelmi
reviewed
Jun 22, 2023
ArtiomDivak
force-pushed
the
issue-189
branch
2 times, most recently
from
0951a59 to
961c3f5
Compare
I added public API to the Manager. Now a user can use the with sdbus to set new log leve for the manger Signed-off-by: Artiom Divak <[email protected]>
The APIs of the node and the agent are connected. The API of Agent is internal. So if the user wants to change the log level for the agent he needs to use the public API of the node Signed-off-by: Artiom Divak <[email protected]>
ArtiomDivak
force-pushed
the
issue-189
branch
3 times, most recently
from
f176674 to
60e3e7b
Compare
engelmi
reviewed
Jun 29, 2023
hirtectl will support set-loglevel command. This command is to set log level on specific node or on the manager. For more info and usage please go to eclipse-bluechi#189 (comment). Signed-off-by: Artiom Divak <[email protected]>
engelmi
approved these changes
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Api feature for setting the log level for the nodes and the manager.
for more details please read #189 (comment)