Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport: Fixed unterminated string initialization #1035

Merged
merged 3 commits into from
Jan 30, 2025

Conversation

engelmi
Copy link
Member

@engelmi engelmi commented Jan 29, 2025

Backport of: #1030
Relates to: https://bugzilla.redhat.com/show_bug.cgi?id=2339937

gcc v15+ will add the static check for unterminated string initialization as default, thus causing the build to fail due to the hexchar function. Since this function uses the char array only for mapping an integer to a hexadecimal char, this error can be ignored.

@engelmi
Copy link
Member Author

engelmi commented Jan 29, 2025

/packit retest-failed

Copy link
Member

@mwperina mwperina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@engelmi
Copy link
Member Author

engelmi commented Jan 29, 2025

Both integration test runs on Testing Farm fail due to the image not found issue - triggered a rebuild of the image, lets see if that helps. Anyway, the failure is unrelated to this change.

@engelmi
Copy link
Member Author

engelmi commented Jan 29, 2025

/packit retest-failed

Signed-off-by: Michael Engel <[email protected]>
Signed-off-by: Michael Engel <[email protected]>
Backport of: eclipse-bluechi#1030
Relates to: https://bugzilla.redhat.com/show_bug.cgi?id=2339937

gcc v15+ will add the static check for unterminated string initialization
as default, thus causing the build to fail due to the hexchar function.
Since this function uses the char array only for mapping an integer to
a hexadecimal char, this error can be ignored.

Signed-off-by: Michael Engel <[email protected]>
@engelmi engelmi force-pushed the backport-gcc-15-fix branch from 1af8bf6 to be1658a Compare January 29, 2025 15:36
@mkemel
Copy link
Member

mkemel commented Jan 30, 2025

/packit test --labels standard

@mkemel mkemel merged commit 17a6603 into eclipse-bluechi:bluechi-0.9.z Jan 30, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants