Skip to content

Commit

Permalink
removed unused sdbus error variable
Browse files Browse the repository at this point in the history
In some of the proxy monitors send function an error
variable had been declared, but not used (due to an
async method call). These can safely be removed.

Signed-off-by: Michael Engel <[email protected]>
  • Loading branch information
engelmi committed Dec 11, 2023
1 parent 92d1fc9 commit fa60204
Showing 1 changed file with 3 additions and 6 deletions.
9 changes: 3 additions & 6 deletions src/manager/proxy_monitor.c
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,6 @@ static int proxy_monitor_send_state_changed_callback(

int proxy_monitor_send_state_changed(
ProxyMonitor *monitor, const char *active_state, const char *substate, const char *reason) {
_cleanup_sd_bus_error_ sd_bus_error error = SD_BUS_ERROR_NULL;
int r = sd_bus_call_method_async(
monitor->node->agent_bus,
NULL,
Expand All @@ -219,7 +218,7 @@ int proxy_monitor_send_state_changed(
bc_log_errorf("Failed to send proxy state changed on node %s object %s: %s",
monitor->node->name,
monitor->proxy_object_path,
error.message);
strerror(-r));
}
return r;
}
Expand All @@ -237,7 +236,6 @@ static int proxy_monitor_send_new_callback(sd_bus_message *m, void *userdata, UN
}

int proxy_monitor_send_new(ProxyMonitor *monitor, const char *reason) {
_cleanup_sd_bus_error_ sd_bus_error error = SD_BUS_ERROR_NULL;
int r = sd_bus_call_method_async(
monitor->node->agent_bus,
NULL,
Expand All @@ -253,7 +251,7 @@ int proxy_monitor_send_new(ProxyMonitor *monitor, const char *reason) {
bc_log_errorf("Failed to send proxy new on node %s object %s: %s",
monitor->node->name,
monitor->proxy_object_path,
error.message);
strerror(-r));
}
return r;
}
Expand All @@ -271,7 +269,6 @@ static int proxy_monitor_send_removed_callback(sd_bus_message *m, void *userdata
}

int proxy_monitor_send_removed(ProxyMonitor *monitor, const char *reason) {
_cleanup_sd_bus_error_ sd_bus_error error = SD_BUS_ERROR_NULL;
int r = sd_bus_call_method_async(
monitor->node->agent_bus,
NULL,
Expand All @@ -287,7 +284,7 @@ int proxy_monitor_send_removed(ProxyMonitor *monitor, const char *reason) {
bc_log_errorf("Failed to send proxy removed on node %s object %s: %s",
monitor->node->name,
monitor->proxy_object_path,
error.message);
strerror(-r));
}
return r;
}

0 comments on commit fa60204

Please sign in to comment.