Reload profile mod list when uninstalling a mod as an installation step #1663
+11
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VilppeRiskidev
commented
Mar 11, 2025
| @@ -85,7 +85,8 @@ export default class DownloadMixin extends Vue { | |||
| assignId: number | |||
| ): Promise<void> { | |||
| await ProfileModList.requestLock(async () => { | |||
| const modList: ManifestV2[] = await installModsToProfile(downloadedMods, profile, undefined,(status, modName, installProgress) => { | |||
| const reloadModList = () => this.$store.dispatch('profile/tryLoadModListFromDisk'); | |||
There was a problem hiding this comment.
This could use updateModList instead of tryLoadModListFromDisk, but that would then require passing the mod list from ProfileUtils' installModsToProfile.
I thought this way would be better as the thing was to make the list match what's on the disk to begin with.
VilppeRiskidev
commented
Mar 11, 2025
| @@ -92,6 +93,9 @@ export async function installModsToProfile( | |||
|
|
|||
| // Uninstall possible different version of the mod before installing the target version. | |||
| throwForR2Error(await ProfileInstallerProvider.instance.uninstallMod(manifestMod, profile)); | |||
| throwForR2Error(await ProfileModList.removeMod(manifestMod, profile)); | |||
There was a problem hiding this comment.
I think this could be called somewhere else, either in DownloadMixin/ImportProfileModal or deeper inside the ProfileInstallerProvider.instance.uninstallMod, but this seemed like the place that most directly represents the actual order of operations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.