Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix semver:compare function #3

Merged
merged 5 commits into from
Feb 6, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,4 @@ target/

*.iml
.idea/
.DS_Store
8 changes: 7 additions & 1 deletion src/main/xquery/semver.xq → src/main/xquery/semver.xqm
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,9 @@ xquery version "3.1";

module namespace semver = "http://exist-db.org/xquery/semver";

declare namespace array="http://www.w3.org/2005/xpath-functions/array";
declare namespace map="http://www.w3.org/2005/xpath-functions/map";

(:~ A regular expression for checking a SemVer version string
: @author David Fichtmueller
: @see https://github.com/semver/semver/pull/460
Expand Down Expand Up @@ -313,7 +316,10 @@ declare function semver:serialize($version as map(*)) {
: @return -1 if v1 < v2, 0 if v1 = v2, or 1 if v1 > v2.
:)
declare function semver:compare($v1 as xs:string, $v2 as xs:string) as xs:integer {
semver:compare($parsed-v1, $parsed-v2, false())
let $parsed-v1 := semver:parse($v1)
let $parsed-v2 := semver:parse($v2)
return
semver:compare-parsed($parsed-v1, $parsed-v2)
};

(:~ Compare two versions (with an option to coerce invalid SemVer strings)
Expand Down
2 changes: 1 addition & 1 deletion src/test/xquery/coerce.xqm
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ xquery version "3.1";

module namespace stco = "http://exist-db.org/xquery/semver/test/coerce";

import module namespace semver = "http://exist-db.org/xquery/semver" at "file:///Users/aretter/code/semver.xq/src/main/xquery/semver.xq";
import module namespace semver = "http://exist-db.org/xquery/semver";

declare namespace test = "http://exist-db.org/xquery/xqsuite";

Expand Down
34 changes: 32 additions & 2 deletions src/test/xquery/compare.xqm
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,37 @@ function stc:lt-pre-release-dot() {
};

declare
%test:assertEquals("false")
%test:assertEquals("true")
function stc:gt() {
semver:lt("2.0.0", "1.0.0")
semver:gt("2.0.0", "1.0.0")
};

declare
%test:assertEquals("true")
function stc:eq() {
semver:eq("1.0.0", "1.0.0")
};

declare
%test:assertEquals("true")
function stc:ne() {
semver:ne("1.0.0", "2.0.0")
};

declare
%test:assertEquals("0")
function stc:compare-eq() {
semver:compare("1.0.0", "1.0.0")
};

declare
%test:assertEquals("1")
function stc:compare-gt() {
semver:compare("2.0.0", "1.0.0")
};

declare
%test:assertEquals("-1")
function stc:compare-lt() {
semver:compare("1.0.0", "2.0.0")
};
2 changes: 1 addition & 1 deletion xar-assembly.xml
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
<namespace>http://exist-db.org/xquery/semver</namespace>
<directory>${basedir}/src/main/xquery</directory>
<includes>
<include>semver.xq</include>
<include>semver.xqm</include>
</includes>
<outputDirectory>content</outputDirectory>
</xquerySet>
Expand Down