Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: invariants for rollapp and sequencer modules #603

Merged
merged 44 commits into from
Mar 3, 2024

Conversation

mtsitrin
Copy link
Contributor

@mtsitrin mtsitrin commented Feb 28, 2024

Description


Closes #421

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow-up issues.

PR review checkboxes:

I have...

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Targeted PR against the correct branch
  • included the correct type prefix in the PR title
  • Linked to the GitHub issue with discussion and accepted design
  • Targets only one GitHub issue
  • Wrote unit and integration tests
  • Wrote relevant migration scripts if necessary
  • All CI checks have passed
  • Added relevant godoc comments

SDK Checklist

  • Import/Export Genesis
  • Registered Invariants
  • Registered Events
  • Updated openapi.yaml
  • No usage of go map
  • No usage of time.Now()
  • Used fixed point arithmetic and not float arithmetic
  • Avoid panicking in Begin/End block as much as possible
  • No unexpected math Overflow
  • Used sendCoin and not SendCoins
  • Out-of-block compute is bounded
  • No serialized ID at the end of store keys

Full security checklist here

For Reviewer:

  • Confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • Confirmed all author checklist items have been addressed

---;

After reviewer approval:

  • In case the PR targets the main branch, PR should not be squash merge in order to keep meaningful git history.
  • In case the PR targets a release branch, PR must be rebased.

Copy link

codecov bot commented Feb 28, 2024

Codecov Report

Attention: Patch coverage is 73.94137% with 80 lines in your changes are missing coverage. Please review.

Project coverage is 30.41%. Comparing base (86db62a) to head (32bb1d5).
Report is 1 commits behind head on main.

Files Patch % Lines
x/rollapp/keeper/invariants.go 65.06% 38 Missing and 13 partials ⚠️
x/sequencer/keeper/invariants.go 65.67% 17 Missing and 6 partials ⚠️
...llapp/keeper/block_height_to_finalization_queue.go 80.64% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #603      +/-   ##
==========================================
+ Coverage   29.97%   30.41%   +0.44%     
==========================================
  Files         199      201       +2     
  Lines       28178    28451     +273     
==========================================
+ Hits         8446     8654     +208     
- Misses      18405    18449      +44     
- Partials     1327     1348      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mtsitrin mtsitrin changed the title feat: invariants for rollapp module feat: invariants for rollapp and sequencer modules Feb 29, 2024
@mtsitrin mtsitrin changed the base branch from main to mtsitrin/496-sequencer-bonding-and-slashing-mvp February 29, 2024 09:39
@mtsitrin mtsitrin marked this pull request as ready for review February 29, 2024 10:04
@mtsitrin mtsitrin requested a review from a team as a code owner February 29, 2024 10:04
@mtsitrin
Copy link
Contributor Author

mtsitrin commented Mar 3, 2024

proposer will be refactored to flag here: #614

omritoptix
omritoptix previously approved these changes Mar 3, 2024
Base automatically changed from mtsitrin/496-sequencer-bonding-and-slashing-mvp to main March 3, 2024 14:08
@mtsitrin mtsitrin dismissed omritoptix’s stale review March 3, 2024 14:08

The base branch was changed.

@mtsitrin mtsitrin requested a review from omritoptix March 3, 2024 14:48
@mtsitrin mtsitrin merged commit 3cf597f into main Mar 3, 2024
6 of 9 checks passed
@mtsitrin mtsitrin deleted the mtsitrin/421-invariants-for-rollapp-module branch March 3, 2024 14:49
@mtsitrin mtsitrin linked an issue Mar 3, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invariants for rollapp module
2 participants