-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: eIBC V1 #493
feat: eIBC V1 #493
Conversation
…der upon underlying packet status update.
…levant memo exists.
… ibc packet upon demand order fulfillment.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #493 +/- ##
==========================================
- Coverage 30.71% 30.70% -0.02%
==========================================
Files 166 200 +34
Lines 25719 28460 +2741
==========================================
+ Hits 7900 8738 +838
- Misses 16552 18324 +1772
- Partials 1267 1398 +131 ☔ View full report in Codecov by Sentry. |
…t malformed packet attacks.
… and update the error.
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
cmd/dymd/__debug_bin4118149964
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove
x/eibc/keeper/msg_server.go
Outdated
if fullfillerAccount == nil { | ||
return nil, types.ErrFullfillerAddressDoesNotExist | ||
} | ||
fullfillerBalance := m.BankKeeper.SpendableCoins(ctx, fullfillerAccount.GetAddress()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's already checked in the SendCoins
Notion site page not found |
Description
Following this feature overview: https://www.notion.so/dymension/eIBC-V1-Feature-Overview-396da8818d5e4ba1a74f2a3e0908582a?pvs=4
Closes #XXX
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow-up issues.
PR review checkboxes:
I have...
Unreleased
section inCHANGELOG.md
godoc
commentsFor Reviewer:
After reviewer approval: