Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't compile against 2.11 #110

Merged
merged 6 commits into from
Jun 26, 2014
Merged

Can't compile against 2.11 #110

merged 6 commits into from
Jun 26, 2014

Conversation

dwhjames
Copy link
Owner

@dwhjames dwhjames commented Jun 6, 2014

Hi,

It would be great to have this library cross-built for 2.10 and 2.11. I tried doing this myself, but am getting errors when I try to compile. I'm not sure of the best approach to fix.

Here are the errors:

[error] /Users/jzulli/Code/datomisca/core/src/main/scala/datomisca/txFunctions.scala:26: in object AddTxFunction, multiple overloaded alternatives of method typed define default arguments.
[error] The members with defaults are defined in object AddTxFunction in package datomisca and trait AddTxFunctionGen in package datomisca and trait AddTxFunctionGen in package datomisca and trait AddTxFunctionGen in package datomisca and trait AddTxFunctionGen in package datomisca and trait AddTxFunctionGen in package datomisca and trait AddTxFunctionGen in package datomisca and trait AddTxFunctionGen in package datomisca and trait AddTxFunctionGen in package datomisca and trait AddTxFunctionGen in package datomisca and trait AddTxFunctionGen in package datomisca and trait AddTxFunctionGen in package datomisca and trait AddTxFunctionGen in package datomisca and trait AddTxFunctionGen in package datomisca and trait AddTxFunctionGen in package datomisca and trait AddTxFunctionGen in package datomisca and trait AddTxFunctionGen in package datomisca and trait AddTxFunctionGen in package datomisca and trait AddTxFunctionGen in package datomisca and trait AddTxFunctionGen in package datomisca and trait AddTxFunctionGen in package datomisca and trait AddTxFunctionGen in package datomisca.
[error] object AddTxFunction extends AddTxFunctionGen {
[error]        ^
[error] /Users/jzulli/Code/datomisca/core/target/scala-2.11/src_managed/main/datomisca/AddTxFunctionGen.scala:21: in trait AddTxFunctionGen, multiple overloaded alternatives of method typed define default arguments.
[error] private[datomisca] trait AddTxFunctionGen {
[error]                          ^
[warn] two warnings found
[error] two errors found
[error] (core/compile:compile) Compilation failed

@dwhjames
Copy link
Owner

dwhjames commented Jun 3, 2014

I have a local branch that sets up cross compilation for 2.10.x and 2.11.x

I think there were a few more issues I wanted to iron out, but I can push the branch that I have thus far, if you’d like to continue on from there.

@GitsMcGee
Copy link
Contributor Author

Sure. Up to you, really. If it's something where I can help out, I'm happy to give it a shot. I personally don't have a pressing need for 2.11 support, so I am happy to wait. It would be a great feature for the community though, I think.

dwhjames added 5 commits June 5, 2014 19:55
- ran into issue with overloads with default args
Conflicts:
	project/Build.scala
	project/build.properties
- provide return types for macros
- use `Future.apply` rather than `future`
- don’t use NotNull
- turn off deprecation warnings for macros due to 2.11
- don’t use global exec context in schema manager
- remove need for DatomicTypeWrapper trait
- annoyingly, still need the DWrapperImpl trick
@dwhjames
Copy link
Owner

dwhjames commented Jun 6, 2014

@mandubian, I touched the wretched/hacky DWrapper thing. NotNull is deprecated in 2.11. I remember you saying once that that was needed to constrain implicit search… or am I misremembering? The DWrapperImpl thing appears to still be needed… I ran into issues with trying to refactor

def list(dw: DWrapper*) = datomic.Util.list(dw.map(_.asInstanceOf[DWrapperImpl].underlying):_*).asInstanceOf[java.util.List[AnyRef]]

- remove JUnit from specs2 tests
dwhjames added a commit that referenced this pull request Jun 26, 2014
@dwhjames dwhjames merged commit 4a75a6c into develop Jun 26, 2014
@dwhjames dwhjames deleted the topic/2.11 branch June 26, 2014 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants