Fix query interpolation for expressions of type String #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strings are not quoted, and they need to be when being substituted into Clojure data
can’t have an abstract value class, but we can still make it behave as one
dwhjames
added a commit
that referenced
this pull request
Apr 21, 2014
Fix query interpolation for expressions of type String
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clojure has both
pr-strandprint-str, the former for consumption by the reader and the latter for human consumption. Scala’stoStringis equivalent toprint-strand does not quote strings. To be able to interpolate expressions of type String, the macro needs to quote the resulting strings, such that they can be read withdatomic.Util.read.Now, when substituting trees of type string, the macro performs a type test for
String.As a small improvement,
AbstractQueryprovides overrides forequals,hashCode, andtoString.