fix bad interaction of null with value classes #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
db.entity and db.entid both return null if given a lookup ref that does not resolve. Constructing the Entity value class from the return value of a method that can return null causes problems. And also, null.asInstanceOf[Long] == 0. This fix tests for nulls and throws exceptions. To be able to test for lookup ref resolution without needing to trap exceptions, helper methods are added to the lookup ref class that return Option.
dwhjames
added a commit
that referenced
this pull request
Apr 21, 2014
fix bad interaction of null with value classes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
db.entity and db.entid both return null if given a lookup ref that does not resolve.
Constructing the Entity value class from the return value of a method that can return null causes problems. And also,
null.asInstanceOf[Long] == 0. This fix tests for nulls and throws exceptions.To be able to test for lookup ref resolution without needing to trap exceptions, helper methods are added to the lookup ref class that return Option.