correct and improve SchemaFact.add/retract and SchemaEntityBuilder #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following should be invalid in Datomic ```clojure [:db/add id :attr [a b c]] ``` However, this was previously permitted. This is now eliminated. The typeclass Attribute2FactWriter is introduced to implement this, and it also has the bonus of being a more efficient implementation over Attribute2PartialAddEntityWriter. Also, expand the methods on SchemaEntityBuilder: ```scala += (attr, val) +?= (attr, optVal) ++= (manyAttr, coll) ++= partialEntity ```
dwhjames
added a commit
that referenced
this pull request
Mar 17, 2014
…alues correct and improve SchemaFact.add/retract and SchemaEntityBuilder
dwhjames
added a commit
that referenced
this pull request
Mar 17, 2014
- fix SchemaFact and SchemaEntity #104 - update version of ScalaTest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following should be invalid in Datomic
However, this was previously permitted. This is now eliminated.
The typeclass
Attribute2FactWriteris introduced to implement this, and it also has the bonus of being a more efficient implementation overAttribute2PartialAddEntityWriter.Also, expand the methods on SchemaEntityBuilder: