Add ACCESSTOKEN support to Aspire Dashboard and YARP internal Dockerfiles #6286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mthalman
reviewed
Feb 27, 2025
...DockerfilesOutput/aspire-dashboard-9.1-azurelinux-distroless-arm64v8-Dockerfile.approved.txt
Outdated
Show resolved
Hide resolved
mthalman
approved these changes
Feb 27, 2025
lbussell
added a commit
to lbussell/dotnet-docker
that referenced
this pull request
Mar 6, 2025
lbussell
added a commit
to lbussell/dotnet-docker
that referenced
this pull request
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of #6254 and #6255.
As there isn't yet support for Aspire Dashboard or YARP in the update-dependencies tooling, I can't tell what the precise download paths will be, so I didn't change them yet. However, this PR sets up the plumbing for using the ACCESSTOKEN arg for these Dockerfile builds so we don't have to do it later.