Fix generated content script warnings on Windows

dotnet · Mar 5, 2025 · 5d16a9c · 5d16a9c
1 parent da89d5c
commit 5d16a9c
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 2 deletions.
diff --git a/eng/DependencyManagement.psm1 b/eng/DependencyManagement.psm1
@@ -33,3 +33,7 @@ function Get-ProductReleaseState() {
         return 'Prerelease'
     }
 }
+
+function Get-DockerOs() {
+    return docker version -f "{{ .Server.Os }}"
+}
diff --git a/eng/dockerfile-templates/Get-GeneratedDockerfiles.ps1 b/eng/dockerfile-templates/Get-GeneratedDockerfiles.ps1
@@ -24,7 +24,9 @@ if (-Not $OutputDirectory) {
 $onDockerfilesGenerated = {
     param($ContainerName)
 
-    if (-Not $Validate) {
+    # On Windows, ImageBuilder is run locally due to limitations with running Docker client within a container.
+    # Remove linux condition when https://github.com/dotnet/docker-tools/issues/159 is resolved
+    if ($(Get-DockerOs) -eq "linux" -and -not $Validate) {
         Exec "docker cp ${ContainerName}:/repo/src $OutputDirectory"
     }
 }

diff --git a/eng/readme-templates/Get-GeneratedReadmes.ps1 b/eng/readme-templates/Get-GeneratedReadmes.ps1
@@ -21,7 +21,9 @@ function CopyReadme([string]$containerName, [string]$readmeRelativePath) {
 $onDockerfilesGenerated = {
     param($ContainerName)
 
-    if (-Not $Validate) {
+    # On Windows, ImageBuilder is run locally due to limitations with running Docker client within a container.
+    # Remove linux condition when https://github.com/dotnet/docker-tools/issues/159 is resolved.
+    if ($(Get-DockerOs) -eq "linux" -and -not $Validate) {
         CopyReadme $ContainerName "README.aspire-dashboard.md"
         CopyReadme $ContainerName "README.aspnet.md"
         CopyReadme $ContainerName "README.md"