-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide analyzer for removing unneeded public partial class Program #58482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
55a4724
to
6a11198
Compare
src/Framework/AspNetCoreAnalyzers/src/CodeFixes/PublicPartialProgramClassFixer.cs
Outdated
Show resolved
Hide resolved
src/Framework/AspNetCoreAnalyzers/test/WebApplicationBuilder/PublicPartialProgramClassTest.cs
Outdated
Show resolved
Hide resolved
martincostello
approved these changes
Oct 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
david-acker
approved these changes
Oct 17, 2024
src/Framework/AspNetCoreAnalyzers/src/CodeFixes/PublicPartialProgramClassFixer.cs
Outdated
Show resolved
Hide resolved
gfoidl
reviewed
Oct 18, 2024
amcasey
reviewed
Oct 25, 2024
...AspNetCoreAnalyzers/src/Analyzers/WebApplicationBuilder/PublicPartialProgramClassAnalyzer.cs
Show resolved
Hide resolved
...AspNetCoreAnalyzers/src/Analyzers/WebApplicationBuilder/PublicPartialProgramClassAnalyzer.cs
Outdated
Show resolved
Hide resolved
src/Framework/AspNetCoreAnalyzers/src/CodeFixes/PublicPartialProgramClassFixer.cs
Outdated
Show resolved
Hide resolved
src/Framework/AspNetCoreAnalyzers/src/CodeFixes/PublicPartialProgramClassFixer.cs
Show resolved
Hide resolved
src/Framework/AspNetCoreAnalyzers/test/WebApplicationBuilder/PublicPartialProgramClassTest.cs
Show resolved
Hide resolved
mgravell
reviewed
Oct 30, 2024
...AspNetCoreAnalyzers/src/Analyzers/WebApplicationBuilder/PublicPartialProgramClassAnalyzer.cs
Outdated
Show resolved
Hide resolved
mgravell
reviewed
Oct 30, 2024
src/Framework/AspNetCoreAnalyzers/test/WebApplicationBuilder/PublicPartialProgramClassTest.cs
Show resolved
Hide resolved
BrennanConroy
approved these changes
Oct 30, 2024
...AspNetCoreAnalyzers/src/Analyzers/WebApplicationBuilder/PublicPartialProgramClassAnalyzer.cs
Show resolved
Hide resolved
mgravell
approved these changes
Oct 31, 2024
captainsafia
added a commit
that referenced
this pull request
Feb 11, 2025
…58482) * Provide analyzer for removing unneeded public partial class Program * Update tests and fix async call * Address feedback * Add test for public partial class with members * Reorganize checks and add tests
Closed
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
analyzer
Indicates an issue which is related to analyzer experience
area-minimal
Includes minimal APIs, endpoint filters, parameter binding, request delegate generator etc
feature-mvc-testing
MVC testing package
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #58199.
Based on the code generation that we introduced earlier, users can get rid of the explicit
public partial class Program { }
declarations in their source code and rely on the new default behavior.This PR introduces an analyzer to find these explicit declarations and a code fixer to remove them.
Implements #58488