Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Pre3] Response streaming default and opt-out #34894

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

[Pre3] Response streaming default and opt-out #34894

wants to merge 5 commits into from

Conversation

guardrex
Copy link
Collaborator

@guardrex guardrex commented Mar 5, 2025 •
edited
Loading

🛑 React to updates 👉 dotnet/runtime#111680.

Fixes #34870

Notes

  • Adds a bit to the existing coverage to include HttpCompletionOption.ResponseHeadersRead.
  • Versions in the new coverage for >=10.0.

Please confirm that this is for Preview 2.

cc: @campersau

Internal previews

📄 File 🔗 Preview link
aspnetcore/blazor/call-web-api.md aspnetcore/blazor/call-web-api

@guardrex guardrex self-assigned this Mar 5, 2025
@guardrex guardrex mentioned this pull request Mar 5, 2025
Open
@guardrex guardrex requested a review from pavelsavara March 5, 2025 17:42
@guardrex guardrex mentioned this pull request Mar 5, 2025
Open
@guardrex
Copy link
Collaborator Author

guardrex commented Mar 5, 2025 •
edited
Loading

@campersau ... In the opt-out case, is ResponseContentRead still the default for HttpCompletionOption? ... and if so, then we don't need to remark on that in the >=10.0 coverage, correct?

@guardrex
Copy link
Collaborator Author

guardrex commented Mar 5, 2025

... and this is for Preview 2, correct?

@guardrex guardrex closed this Mar 5, 2025
@guardrex guardrex reopened this Mar 5, 2025
@guardrex guardrex mentioned this pull request Mar 6, 2025
Open
@pavelsavara
Copy link
Member

Please confirm that this is for Preview 2.

Probably preview3, but it's not done yet.

@guardrex guardrex changed the title Response streaming default and opt-out [Pre3] Response streaming default and opt-out Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@campersau campersau campersau left review comments

@pavelsavara pavelsavara Awaiting requested review from pavelsavara

Assignees

@guardrex guardrex

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Response streaming opt-out
3 participants
@guardrex @pavelsavara @campersau