-
Notifications
You must be signed in to change notification settings - Fork 25.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Secure data with Interactive Auto rendering #34765
base: main
Are you sure you want to change the base?
Conversation
|
||
protected override async Task OnInitializedAsync() | ||
{ | ||
persistingSubscription = ApplicationState.RegisterOnPersisting(PersistData); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@javiercn Is this the best way to use PersistentComponentState
? Is there any risk of PersistData
getting called before GetWeatherForecastAsync
completes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It could happen if the application is shut down before GetWeatherForecastAsync
completes
@halter73 ... Is your question for @javiercn ☝️ blocking? You know, that code is directly out of the sample apps. Otherwise if you and @mikekistler don't see any problems, particularly with my remarks at the end of the new section, we should be able to merge this fairly quickly. My main concern is this language ...
|
Ping @halter73 ... Is this blocked on your question? Otherwise, is there anything wrong with the guidance at the end of the section ☝️. |
Fixes #34586
Thanks @davisnw! 🚀 ... Your product unit issue (
dotnet/aspnetcore
#60184) will be reviewed by engineering for possible improvements to the framework in a future release. For the docs, I'm making the following updates:I decided not to change the existing Call web API sample apps at this time. We have enough security examples that make secure web API calls, including WASM and server-based examples, to cover it. The problem was just that most of the samples are new and unlinked ... not anymore after this goes in 😄.
I'll get a security review on this PR. I'm not too concerned about my general remarks. I'd like to hear from any or all of Javier, Stephen, and Mike on the language used at the end of the new section. I'd like to know if they want to say something different or add guidance to it.
Internal previews