WN: P1 #34741
Merged
WN: P1 #34741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rick-Anderson
commented
Feb 15, 2025
There was a problem hiding this comment.
@mikekistler I copy/pasted your markup from the P1 issue and merged into main. This PR shows the diffs. If you remember, don't add newlines unless you need a new line. The diff is a bit hard to read because I've removed newlines.
I think rich diff is the most productive way to see what has changed.
Comment on lines
-3
to
-4
| https://github.com/dotnet/aspnetcore/pull/59480 | ||
| https://github.com/dotnet/aspnetcore/pull/60002 |
There was a problem hiding this comment.
Duplicate PR, is there another? I added the PR at the end of the H3
| - Instead of a `nullable: true` property, they have a `type` keyword whose value is an array that includes `null` as one of the types. | ||
|
|
||
| With this feature, the default OpenAPI version for generated documents will be `3.1` . You can easily change the version | ||
| by explicitly setting the [OpenApiVersion](/dotnet/api/microsoft.aspnetcore.openapi.openapioptions.openapiversion?view=aspnetcore-9.0) property of the [OpenApiOptions](/dotnet/api/microsoft.aspnetcore.openapi.openapioptions?view=aspnetcore-9.0) in the `configureOptions` delegate parameter of [AddOpenApi](/dotnet/api/microsoft.extensions.dependencyinjection.openapiservicecollectionextensions.addopenapi?view=aspnetcore-9.0). |
There was a problem hiding this comment.
@mikekistler can you check these links (click on them in the build)
Rick-Anderson
commented
Feb 15, 2025
| @@ -77,22 +73,47 @@ In .NET 10 the transformer to do the same task will look like this: | |||
| }); | |||
| ``` | |||
|
|
|||
| Note that these changes will be necessary even if you congfigure the OpenAPI version to 3.0. | |||
| The following example shows the changes in diff format. | |||
There was a problem hiding this comment.
@mikekistler should I delete the before/after code and just have the diff? I prefer the diff.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #34723
Fixes #34727
Internal previews