-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable cracklib check password #4991
Conversation
Cracklib based password check is temporarly disabled while the selinux policy is updated to allow its usage.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll defer to @ladycfu but to my understanding we're only removing it from the default profiles and the code still supports the cracklibCheck
param, so we probably should keep the docs since it's an optional param.
I just noticed this, should it be checking CONFIG_PASSWORD_CRACKLIB_CHECK instead?
https://github.com/dogtagpki/pki/blob/master/base/ca/src/main/java/com/netscape/cms/profile/constraint/P12ExportPasswordConstraint.java#L165-L167
And it probably needs to be added here too:
https://github.com/dogtagpki/pki/blob/master/base/ca/src/main/java/com/netscape/cms/profile/constraint/P12ExportPasswordConstraint.java#L79-L85
This check if numerical options are parsed correctly. Boolean parse all the string and match to true or false without generating error so there is no need to add in this method. |
Doc is not working if selinux is enabled. |
Do we want to allow people to use cracklib with selinux disabled? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Cracklib based password check is temporarly disabled while the selinux policy is updated to allow its usage.