-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reset .markdown-section max-width to 800px #2429
Comments
Thanks for filing the issue, @cippaciong. TL;DR: We can address readability concerns and personal line-length preferences by doing the following:
Details (for those who care)... Some people will inevitably feel that the new markdown container width looks/feels too narrow. The criticism isn't necessarily wrong. All of the Docsify alternatives I tested have line lengths greater than 80 (see below). Every one of those alternatives also renders both left and right sidebars which help fill the horizontal space. Docsify, by comparison, will have a narrower overall content width which some people may not care for. There are a few additional things we can do to try and reduce (but not eliminate) these concerns:
For comparison, here are the default line length, font size, and content container width values from a few Docsify alternatives:
Finally, here are the line lengths using Docsify's Source Sans Pro (used in vue.css)
Based on these numbers, reverting the max-width to |
- Add configurable max-width (Fix #2429) - Add z-index vars for maintainability - Fix .content style conflicts - Update navbar and GitHub corner styles
Thanks @cippaciong for identifying this issue and @jhildenbiddle for the detailed analysis and possible options etc. In addition to numerical line lengths I think we could consider a few other aspects as well. For example, many folks have grown accustomed to the information density of the current 80% of screen width currently in Docsify (and possibly manually adjust their Browser windows to their liking). In addition, with digital text there are also other aspects coming into play such as the need to scroll to read and how much scrolling is involved etc. Here is a helpful article that highlights these additional aspects for reference: I don't think there is an ideal answer to a revised Markdown section width for Docsify, and the current 80% of screen has a lot of readability issues. 800px width may not be ideal either, but given the display of digital text and related aspects, somewhere around there some good candidates might still exist. |
This issue has been addressed by PR #2469. The changes will be available when Docsify v5 is released. Once v5 is release, this issue can be resolved by modifying the following theme property: :root {
--content-max-width: 72ch;
} |
Feature request
Reset .
markdown-section
max-width
to800px
or a similar valueProblem or desire
Docsify used to limit articles
max-width
to800px
but this was changed to80%
in #1017, claiming that such value would look better on wider screens.As already mentioned by @jhildenbiddle in a comment to that PR, I think this was a mistake since that would negatively affect the readability of the content.
IMO that change lead to two regressions:
80%
would introduce unwanted margins in that scenario. See for example this comment and Restoremax-width
to100%
if viewport is less than 768px #1273Proposal
Restore .markdown-section max-width to
800px
or a similar value.Implementation
I'm not an expert, but I should manage to submit a PR if maintainers consider this change acceptable
The text was updated successfully, but these errors were encountered: