Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: npm audit issues #65

Merged
merged 1 commit into from
Nov 20, 2019
Merged

fix: npm audit issues #65

merged 1 commit into from
Nov 20, 2019

Conversation

L2jLiga
Copy link
Contributor

@L2jLiga L2jLiga commented Oct 12, 2019

No description provided.

@L2jLiga
Copy link
Contributor Author

L2jLiga commented Oct 27, 2019

@QingWei-Li can you take a look?

anikethsaha
anikethsaha requested changes Nov 18, 2019
View reviewed changes
Copy link
Member

@anikethsaha anikethsaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase and resolve the conflicts. And try running the audit again.
Most of the outdated packages were just updated.

@L2jLiga
Copy link
Contributor Author

L2jLiga commented Nov 19, 2019

branch: master
command: npm ci && npm audit
result:

found 15 vulnerabilities (3 low, 2 moderate, 10 high) in 1689 scanned packages
  run `npm audit fix` to fix 11 of them.
  4 vulnerabilities require manual review. See the full report for details.

this PR:

found 4 vulnerabilities (2 low, 2 moderate) in 2736 scanned packages
  4 vulnerabilities require manual review. See the full report for details.

all PR vulnerabilities found in docsify and docsify-server-renderer

@L2jLiga L2jLiga requested a review from anikethsaha November 19, 2019 08:55
@anikethsaha
Copy link
Member

Thanks for that detailed comment.
I will take a look soon.
I guess we need to update some packages in the main repo as well.

@L2jLiga
Copy link
Contributor Author

L2jLiga commented Nov 19, 2019

PR for updating packages in main repo already in master: docsifyjs/docsify#934

anikethsaha
anikethsaha approved these changes Nov 19, 2019
View reviewed changes
Copy link
Member

@anikethsaha anikethsaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
just waiting for the main repo release. If that is in hanging I will merge this and release this one

@anikethsaha anikethsaha merged commit e0c9558 into docsifyjs:master Nov 20, 2019
@anikethsaha
Copy link
Member

Released https://www.npmjs.com/package/docsify-cli/v/4.4.0 👍

@L2jLiga L2jLiga deleted the audit-fix branch November 20, 2019 15:20
@L2jLiga L2jLiga mentioned this pull request Nov 27, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anikethsaha anikethsaha anikethsaha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@L2jLiga @anikethsaha