Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

note about usage of summary feature with download-artifact action #1337

Merged
merged 1 commit into from
Mar 10, 2025

Conversation

README.md Outdated
>
> If you're using the [`actions/download-artifact`](https://github.com/actions/download-artifact)
> action in your workflow, you need to ignore the build record artifacts
> if you don't specify the `name` input (download all artifacts), otherwise the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is "name" input? You mean "pattern" ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No I really mean name: https://github.com/actions/download-artifact/blob/cc203385981b70ca67e1cc392babf9cc229d5806/action.yml#L5-L7

Maybe I can just remove this part if that's confusing

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, it is confusing because the example is using pattern. If we want to be very clear, I think we should provide examples for both name and pattern.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to explain that this applies only if name and pattern are not set.

@crazy-max crazy-max force-pushed the note-download-artifact branch from 6b5ebd8 to 9bea05f Compare March 10, 2025 10:16
@crazy-max crazy-max requested a review from tonistiigi March 10, 2025 10:18
@crazy-max crazy-max merged commit 84ad562 into docker:master Mar 10, 2025
65 checks passed
@crazy-max crazy-max deleted the note-download-artifact branch March 10, 2025 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants