Skip to content

Add Windows Server 2022 images for 3.9 and 3.10-rc #643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 2, 2021
Merged

Add Windows Server 2022 images for 3.9 and 3.10-rc #643

merged 1 commit into from
Sep 2, 2021

Conversation

TBBle
Copy link
Contributor

@TBBle TBBle commented Aug 27, 2021

Tested on a Windows Server 2022 evaluation install in a Hyper-V VM, using Mirantis Container Runtime 20.10.6 from DockerMsftProvider.

Basic tests for functionality, for both new Dockerfiles, downloaded into otherwise-empty directories:

PS C:\Users\Administrator\3.9> docker build . -t py39
Sending build context to Docker daemon  4.608kB
Step 1/11 : FROM mcr.microsoft.com/windows/servercore:ltsc2022
...
Successfully tagged py39:latest
PS C:\Users\Administrator\3.9> docker run py39 python -c "import platform; print(platform.win32_ver()); import sys; print(sys.version)"
('10', '10.0.20348', 'SP0', 'Multiprocessor Free')
3.9.6 (tags/v3.9.6:db3ff76, Jun 28 2021, 15:26:21) [MSC v.1929 64 bit (AMD64)]
PS C:\Users\Administrator\3.10-rc> docker build . -t py310rc
Sending build context to Docker daemon  4.608kB
Step 1/11 : FROM mcr.microsoft.com/windows/servercore:ltsc2022
...
Successfully tagged py310rc:latest
PS C:\Users\Administrator\3.10-rc> docker run py310rc python -c "import platform; print(platform.win32_ver()); import sys; print(sys.version)"
('10', '10.0.20348', 'SP0', 'Multiprocessor Free')
3.10.0rc1 (tags/v3.10.0rc1:cc115e5, Aug  3 2021, 15:22:01) [MSC v.1929 64 bit (AMD64)]
  • Test the images (either CI-generated, or just run the Dockerfiles locally)
  • Internal sign-off per Wargaming.net Open Source contribution policy (2/2 done)

@TBBle TBBle marked this pull request as ready for review August 30, 2021 07:37
@TBBle
Copy link
Contributor Author

TBBle commented Sep 2, 2021

CI has previously passed for Windows Server 2022, but rebasing to pull bb70f32 has put it back into the workflow-approval queue.

@tianon tianon merged commit bb2e1c7 into docker-library:master Sep 2, 2021
@tianon
Copy link
Member

tianon commented Sep 2, 2021

Looks good, thanks!

docker-library-bot added a commit to docker-library-bot/official-images that referenced this pull request Sep 2, 2021
Changes:

- docker-library/python@5b1611f: Update to 3.9.7, pip 21.2.4
- docker-library/python@bb2e1c7: Merge pull request docker-library/python#643 from TBBle/Windows_Server_2022-images
- docker-library/python@daf9e7d: Add Windows Server 2022 images for 3.9 and 3.10-rc
@TBBle TBBle deleted the Windows_Server_2022-images branch September 3, 2021 08:25
@tianon tianon mentioned this pull request Feb 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants