Skip to content

Update configuration File (php.ini) Path #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 6, 2015
Merged

Update configuration File (php.ini) Path #149

merged 3 commits into from
Feb 6, 2015

Conversation

shafan
Copy link

@shafan shafan commented Feb 4, 2015

The configuration File Path is not /usr/local/bin but /usr/local/etc/php

The configuration File Path is not /usr/local/bin but /usr/local/etc/php
@tianon
Copy link
Member

tianon commented Feb 4, 2015

LGTM:

PHP_INI_DIR => /usr/local/etc/php

@yosifkit
Copy link
Member

yosifkit commented Feb 4, 2015

LGTM

@yosifkit
Copy link
Member

yosifkit commented Feb 4, 2015

Can you put this in the content.md?

@tianon tianon added the moreinfo label Feb 4, 2015
@shafan
Copy link
Author

shafan commented Feb 5, 2015

ok

@yosifkit
Copy link
Member

yosifkit commented Feb 5, 2015

Thanks!

@shafan
Copy link
Author

shafan commented Feb 6, 2015

Now it's good

@@ -59,7 +59,7 @@ We recommend that you add a custom `php.ini` configuration. `COPY` it into
same commands to build and run:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's one more in this paragraph that you appear to have missed when you copied the change over. 👍

@shafan
Copy link
Author

shafan commented Feb 6, 2015

oups sorry, now it's good

@tianon
Copy link
Member

tianon commented Feb 6, 2015

LGTM

@yosifkit
Copy link
Member

yosifkit commented Feb 6, 2015

LGTM

yosifkit added a commit that referenced this pull request Feb 6, 2015
Update configuration File (php.ini) Path
@yosifkit yosifkit merged commit 93560d3 into docker-library:master Feb 6, 2015
@shafan shafan deleted the patch-1 branch February 6, 2015 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants