Store categories from pandas. #11303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
|
I need to either find a fix for the hang or disable the test. |
trivialfis
commented
Mar 4, 2025
| @@ -1240,6 +1251,70 @@ def get_quantile_cut(self) -> Tuple[np.ndarray, np.ndarray]: | |||
| assert data.dtype == np.float32 | |||
| return indptr, data | |||
|
|
|||
| def get_categories(self) -> Optional[Dict[str, "pa.DictionaryArray"]]: | |||
There was a problem hiding this comment.
We might one day generalize this into an arrow encoder/decoder. For now, it's just glue code.
trivialfis
commented
Mar 4, 2025
| @@ -718,6 +720,56 @@ XGB_DLL int XGDMatrixGetStrFeatureInfo(DMatrixHandle handle, const char *field, | |||
| API_END(); | |||
| } | |||
|
|
|||
| XGB_DLL int XGBDMatrixGetCategories(DMatrixHandle handle, char const **out) { | |||
There was a problem hiding this comment.
The function is hidden due to WIP.
rongou
approved these changes
Mar 4, 2025
- Change host columnar adapter to receive categories. - Store categories in the meta info. - Glue code for the Python interface.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DMatrix.Other DMatrix types are not supported yet.