Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: redirect to home page after project created #587

Merged
merged 7 commits into from
Sep 14, 2023
Merged

fix: redirect to home page after project created #587

merged 7 commits into from
Sep 14, 2023

Conversation

harshmangalam
Copy link
Contributor

No description provided.

This was referenced Sep 13, 2023
Closed
Closed
iuioiua
iuioiua approved these changes Sep 13, 2023
View reviewed changes
Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

iuioiua
iuioiua suggested changes Sep 13, 2023
View reviewed changes
Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, please fix the test case.

@harshmangalam
Copy link
Contributor Author

@iuioiua fixed tests cases

iuioiua
iuioiua suggested changes Sep 13, 2023
View reviewed changes
Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please revert the formatting changes. These changes are unrelated to the PR's objective and add noise to the diff.

@harshmangalam
Copy link
Contributor Author

@iuioiua fixed fmt issues

@iuioiua
Copy link
Contributor

iuioiua commented Sep 14, 2023

Closes #584

iuioiua
iuioiua approved these changes Sep 14, 2023
View reviewed changes
Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT. Thank you.

@iuioiua iuioiua merged commit a36a206 into denoland:main Sep 14, 2023
@harshmangalam harshmangalam deleted the issues-584 branch September 14, 2023 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iuioiua iuioiua iuioiua approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@harshmangalam @iuioiua