fix(check): CJS types importing dual ESM/CJS package should prefer CJS types #24492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
commented
Jul 9, 2024
| @@ -66,8 +67,7 @@ pub struct ModuleCodeStringSource { | |||
|
|
|||
| #[derive(Debug)] | |||
| pub struct CliNodeResolver { | |||
| // not used in the LSP | |||
| cjs_resolutions: Option<Arc<CjsResolutionStore>>, | |||
| cjs_resolutions: Arc<CjsResolutionStore>, | |||
There was a problem hiding this comment.
This means we have this cache in two places for the LSP (here and in the JS code), which is not ideal.
There was a problem hiding this comment.
I guess we can address this in a follow up?
bartlomieju
approved these changes
Jul 10, 2024
Comment on lines
+500
to
+501
| // it's not ideal to share this across all scopes and to | ||
| // never clear it, but it's fine for the time being |
There was a problem hiding this comment.
Add a TODO and open an issue so we don't forget?
There was a problem hiding this comment.
I initially had one, but removed it because it seems ok and we can fix this once we get a bug that causes us to need to fix it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16370