-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(ws): optimize fastwebsockets in release profile #24277
Conversation
oh interesting 🤔 we should probably re-enable explicit SIMD then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I think you don't have to.
|
This sorts and re-aligns the
bench
andrelease
profiles, notably enabling optimizations forfastwebsockets
in the released CLI binary.The goal is to unlock auto-vectorization for ws hotpaths, as noted in https://github.com/denoland/fastwebsockets/blob/0.7.0/src/mask.rs#L22 (contrarily to that comment, disassembling the amd64
deno
1.44 binary shows no SIMD instructions in ws-unmasking logic).