feat: Handle package.json lifecycle scripts #23558
Closed
+626
−397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
reviewed
Apr 25, 2024
| @@ -648,6 +737,39 @@ fn get_package_folder_id_from_folder_name( | |||
| }) | |||
| } | |||
|
|
|||
| fn symlink_bin_entry( | |||
There was a problem hiding this comment.
We have some code somewhere else that handles doing a symlink like this on unix and will use junctions on windows. It would be good to reuse that code here.
There was a problem hiding this comment.
Or actually, I guess since this is setting up scripts for windows we should have it create something executable here for that.
dsherret
reviewed
Apr 25, 2024
cli/npm/managed/resolvers/local.rs
Outdated
| log::warn!(" Do you want to run this script with full permissions? [y/N]"); | ||
| // ASCII code for the bell character. | ||
| print!("\x07"); | ||
| eprint!(" > "); |
There was a problem hiding this comment.
Could a previously executing script stuff stdin? We should maybe re-use the permission prompt code here somehow?
This was referenced May 21, 2024
Merged
3 tasks
|
Closing in favor of #24487 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked by #23498Blocked by #23496Blocked by denoland/deno_npm#47Blocked by denoland/eszip#182