-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Spark] Fix replacing clustered table with non-clustered table #3175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dabao521
reviewed
May 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me with a few comments, thanks!
spark/src/test/scala/org/apache/spark/sql/delta/skipping/ClusteredTableTestUtils.scala
Show resolved
Hide resolved
spark/src/test/scala/org/apache/spark/sql/delta/skipping/ClusteredTableTestUtils.scala
Show resolved
Hide resolved
spark/src/test/scala/org/apache/spark/sql/delta/skipping/ClusteredTableTestUtils.scala
Show resolved
Hide resolved
spark/src/main/scala/org/apache/spark/sql/delta/skipping/clustering/ClusteredTableUtils.scala
Outdated
Show resolved
Hide resolved
...k/src/test/scala/org/apache/spark/sql/delta/skipping/clustering/ClusteredTableDDLSuite.scala
Show resolved
Hide resolved
...k/src/test/scala/org/apache/spark/sql/delta/skipping/clustering/ClusteredTableDDLSuite.scala
Show resolved
Hide resolved
dabao521
approved these changes
May 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix!
zedtang
added a commit
to zedtang/delta
that referenced
this pull request
Jun 3, 2024
…-io#3175) ## Description Fix replacing clustered table with non-clustered table, by creating a domain metadata with empty clustering columns. ## How was this patch tested? New UTs.
richardc-db
pushed a commit
to richardc-db/delta
that referenced
this pull request
Jun 5, 2024
…-io#3175) ## Description Fix replacing clustered table with non-clustered table, by creating a domain metadata with empty clustering columns. ## How was this patch tested? New UTs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Delta project/connector is this regarding?
Description
Fix replacing clustered table with non-clustered table, by creating a domain metadata with empty clustering columns.
How was this patch tested?
New UTs.
Does this PR introduce any user-facing changes?
No