[Spark] Add managed-commit table feature and CommitStore interface #2627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prakharjain09
force-pushed
the
mc-feature-commitstore
branch
from
836b253 to
294e7ce
Compare
ryan-johnson-databricks
approved these changes
Feb 9, 2024
spark/src/main/scala/org/apache/spark/sql/delta/managedcommit/CommitStore.scala
Outdated
Show resolved
Hide resolved
spark/src/main/scala/org/apache/spark/sql/delta/util/FileNames.scala
Outdated
Show resolved
Hide resolved
spark/src/main/scala/org/apache/spark/sql/delta/util/FileNames.scala
Outdated
Show resolved
Hide resolved
Comment on lines
+118
to
+119
| val dir = new File(rootDir, "_delta_log") | ||
| dir.mkdir() |
There was a problem hiding this comment.
Yikes... this test was creating Delta metadata files directly in the table dir?
ryan-johnson-databricks
approved these changes
Feb 12, 2024
...ain/scala/org/apache/spark/sql/delta/managedcommit/AbstractBatchBackfillingCommitStore.scala
Outdated
Show resolved
Hide resolved
...ain/scala/org/apache/spark/sql/delta/managedcommit/AbstractBatchBackfillingCommitStore.scala
Outdated
Show resolved
Hide resolved
spark/src/main/scala/org/apache/spark/sql/delta/managedcommit/CommitStore.scala
Outdated
Show resolved
Hide resolved
spark/src/main/scala/org/apache/spark/sql/delta/managedcommit/CommitStore.scala
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Delta project/connector is this regarding?
Description
Add Managed Commit table feature and Commit Store interface.
Related issue: #2598
How was this patch tested?
UTs
Does this PR introduce any user-facing changes?
No