Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove mention of 2.0 from banner #9010

Merged
merged 3 commits into from
Mar 11, 2025
Merged

chore: remove mention of 2.0 from banner #9010

merged 3 commits into from
Mar 11, 2025

Conversation

julian-risch
Copy link
Member

@julian-risch julian-risch commented Mar 10, 2025

Related Issues

Proposed Changes:

  • Crop the banner image so that version 2.0 is not mentioned anymore

How did you test it?

Does not apply

Notes for the reviewer

The banner is linked to for example from the cookbook README.md.

Checklist

  • I have read the contributors guidelines and the code of conduct
  • I have updated the related issue with new insights and changes
  • I added unit tests and updated the docstrings
  • I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test: and added ! in case the PR includes breaking changes.
  • I documented my code
  • I ran pre-commit hooks and fixed any issue

@julian-risch julian-risch requested a review from a team as a code owner March 10, 2025 22:12
@julian-risch julian-risch requested review from mpangrazzi and bilgeyucel and removed request for a team and mpangrazzi March 10, 2025 22:12
Copy link
Contributor

@bilgeyucel bilgeyucel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a new banner with the new logo

@julian-risch
Copy link
Member Author

julian-risch commented Mar 11, 2025

@bilgeyucel Before we merge, we need to make check what other pages link to the deleted banner_20.png.
It's haystack, haystack-cookbook and haystack-tutorials repo README files.
Edit: and demos

@julian-risch julian-risch merged commit 195d403 into main Mar 11, 2025
5 checks passed
@julian-risch julian-risch deleted the update-banner branch March 11, 2025 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants