Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor:Remove the read_atom_species and add read_lattice_constant #5828

Merged
merged 19 commits into from
Jan 9, 2025
Merged

Refactor:Remove the read_atom_species and add read_lattice_constant #5828

merged 19 commits into from
Jan 9, 2025

Conversation

A-006
Copy link
Collaborator

@A-006 A-006 commented Jan 7, 2025

Linked Issue

Fix #...

Unit Tests and/or Case Tests for my changes

  • Modify the unittest of the read_atom_species

What's changed?

  • modify read_atom_species,add the read_atom_species.cpp
  • Add func read_lattice_constant to read the lattice_constant
  • modify the atom_mass,atom_lable,pesudo_fn,pesudo_type to vector.

@A-006 A-006 marked this pull request as draft January 7, 2025 04:20
@mohanchen mohanchen added the The Absolute Zero Reduce the "entropy" of the code to 0 label Jan 8, 2025
@A-006 A-006 marked this pull request as ready for review January 8, 2025 06:55
@mohanchen mohanchen merged commit beeb256 into deepmodeling:develop Jan 9, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohanchen mohanchen mohanchen approved these changes

Assignees
No one assigned
Labels
The Absolute Zero Reduce the "entropy" of the code to 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@A-006 @mohanchen