Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests: add checks for opening data files by hsolver tests #5823

Merged
merged 2 commits into from
Jan 6, 2025
Merged

Tests: add checks for opening data files by hsolver tests #5823

merged 2 commits into from
Jan 6, 2025

Conversation

Cstandardlib
Copy link
Collaborator

Unit Tests and/or Case Tests for my changes

  • Add checks for hsolver tests so that it will pop a warning and quit if data files cannot be opened normally. Current test will stuck if the data file required by ifstream does not exist in working directory.

@mohanchen mohanchen added the Refactor Refactor ABACUS codes label Jan 6, 2025
@mohanchen mohanchen merged commit cdf1c04 into deepmodeling:develop Jan 6, 2025
14 checks passed
@Cstandardlib Cstandardlib deleted the tests/hsolver-add-file-check branch January 6, 2025 13:26
kluophysics pushed a commit to kluophysics/abacus-develop that referenced this pull request Jan 10, 2025
@Cstandardlib @pre-commit-ci-lite @kluophysics
Tests: add checks for opening data files by hsolver tests (deepmodeli…
7546d6f 
…ng#5823)

* Tests: add checks for opening data files by hsolver tests

* [pre-commit.ci lite] apply automatic fixes

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohanchen mohanchen mohanchen approved these changes

Assignees
No one assigned
Labels
Refactor Refactor ABACUS codes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Cstandardlib @mohanchen