Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor:Move the relaxation part of the ucell function #5767

Merged
merged 9 commits into from
Dec 28, 2024

Conversation

A-006
Copy link
Collaborator

@A-006 A-006 commented Dec 25, 2024

Unit Tests and/or Case Tests for my changes

  • Modify the funciton of remake_cell,setup_cell_after_vc in unittest.
  • The unit test of setup_cell_after_vc is not check in the before,add the result for this func.

What's changed?

  • move function of remake_cell,setup_cell_after_vc in ucell to update_ucell.cpp
  • The remake_cell function is not run in the relax_test.cpp,add the test for this func.

@mohanchen mohanchen added the The Absolute Zero Reduce the "entropy" of the code to 0 label Dec 27, 2024
@mohanchen mohanchen merged commit 5e8bc21 into deepmodeling:develop Dec 28, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
The Absolute Zero Reduce the "entropy" of the code to 0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants