A refactoring PR of send_v1 method #104
Conversation
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| before do | ||
| expect(json_key_path).to receive(:respond_to?).and_return(true) | ||
| expect(Google::Auth::ServiceAccountCredentials).to receive_message_chain(:make_creds).and_return(authorizer_double) | ||
| expect(authorizer_double).to receive(:fetch_access_token!).and_return({ "access_token" => access_token }) |
There was a problem hiding this comment.
Style/BracesAroundHashParameters: Redundant curly braces around a hash parameter.
Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
Metrics/LineLength: Line is too long. [111/80]
|
|
||
| before do | ||
| expect(json_key_path).to receive(:respond_to?).and_return(true) | ||
| expect(Google::Auth::ServiceAccountCredentials).to receive_message_chain(:make_creds).and_return(authorizer_double) |
There was a problem hiding this comment.
Metrics/LineLength: Line is too long. [121/80]
| end | ||
|
|
||
| let(:authorizer_double) { double("token_fetcher") } | ||
| let(:json_key_path) { double("file alike object") } |
There was a problem hiding this comment.
Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
| ) | ||
| end | ||
|
|
||
| let(:authorizer_double) { double("token_fetcher") } |
There was a problem hiding this comment.
Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
| # ref: https://firebase.google.com/docs/cloud-messaging/http-server-ref#interpret-downstream | ||
| body: "{}", | ||
| headers: {}, | ||
| status: 200, |
There was a problem hiding this comment.
Style/TrailingCommaInArguments: Avoid comma after the last parameter of a method call.
| headers: valid_request_v1_headers, | ||
| ).to_return( | ||
| # ref: https://firebase.google.com/docs/cloud-messaging/http-server-ref#interpret-downstream | ||
| body: "{}", |
There was a problem hiding this comment.
Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
| let(:valid_request_v1_headers) do | ||
| { | ||
| "Content-Type" => "application/json", | ||
| "Authorization" => "Bearer #{access_token}", |
There was a problem hiding this comment.
Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
Style/TrailingCommaInHashLiteral: Avoid comma after the last item of a hash.
| let(:access_token) { "access_token" } | ||
| let(:valid_request_v1_headers) do | ||
| { | ||
| "Content-Type" => "application/json", |
There was a problem hiding this comment.
Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
| pending "should send message" | ||
| let(:project_name) { "project_name" } | ||
| let(:send_v1_url) { "#{FCM::BASE_URI_V1}#{project_name}/messages:send" } | ||
| let(:access_token) { "access_token" } |
There was a problem hiding this comment.
Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
| @@ -24,7 +24,75 @@ | |||
| end | |||
|
|
|||
| describe "#send_v1" do | |||
| pending "should send message" | |||
| let(:project_name) { "project_name" } | |||
There was a problem hiding this comment.
Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
| extra_headers = { | ||
| 'Authorization' => "Bearer #{jwt_token}" | ||
| } | ||
| for_uri(BASE_URI_V1, extra_headers) do |connection| |
Just add a few refactoring code, mainly for
#send_v1methodadd rspec test for #send_v1 method
refactor #send_v1 method
#for_uri(BASE_URI_V1, extra_headers) do endprivate methoddelete unused var / constant / comment
delete
attr_accessor :timeout, :api_key, :json_key_path, :project_base_uri