Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show activity graphs on admin dashboard #6030

Merged
merged 19 commits into from
May 4, 2020
Merged

Show activity graphs on admin dashboard #6030

merged 19 commits into from
May 4, 2020

Conversation

mrcasals
Copy link
Contributor

@mrcasals mrcasals commented Apr 27, 2020 •
edited
Loading

🎩 What? Why?

This PR adds the activity graphs to the admin dashboard.

📌 Related Issues

📋 Subtasks

  • Add CHANGELOG entry
  • Add tests

📷 Screenshots (optional)

Dashboard:

image

All graphs:

image

@mrcasals mrcasals self-assigned this Apr 27, 2020
@mrcasals mrcasals added contract: PAM2020 Barcelona City Council contract status: WIP labels Apr 28, 2020
@mrcasals mrcasals marked this pull request as ready for review April 28, 2020 10:00
@mrcasals mrcasals requested review from agustibr and leio10 April 28, 2020 10:38
leio10
leio10 previously approved these changes Apr 28, 2020
View reviewed changes
Copy link
Contributor

@leio10 leio10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mrcasals
Copy link
Contributor Author

@decidim/core this has been approved by @decidim/product, can you review it please? 😄

agustibr
agustibr previously approved these changes Apr 28, 2020
View reviewed changes
Copy link
Contributor

@agustibr agustibr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tramuntanal
Copy link
Contributor

Hi @mrcasals it seems all tests are failing. Can you check please before we start reviewing?

@mrcasals
Copy link
Contributor Author

@decidim/core all green now! Can you review it please?

@mrcasals mrcasals requested a review from a team May 4, 2020 08:58
Leusev
Leusev suggested changes May 4, 2020
View reviewed changes
Copy link
Contributor

@Leusev Leusev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mrcasals
it seems good for me! Good job!
In my opinion, there's have been a good refactor in metric_charts_presenter and well done extending it in dashboard_metric_charts_presenter in admin.
Finally, seems that codecov/patch test fails, maybe you could add some more tests in admin_checks_metrics_spec ?
Thanks in advance!

@mrcasals
Copy link
Contributor Author

mrcasals commented May 4, 2020 •
edited
Loading

Hi @Leusev! I've added more tests. The check fails because the budgets engine failed to upload the coverage.

Can you approve and merge this PR please? /cc @decidim/core

@tramuntanal tramuntanal merged commit a15cfe7 into develop May 4, 2020
@tramuntanal tramuntanal deleted the admin/show-metrics-in-dashboard branch May 4, 2020 15:31
ace pushed a commit to aspgems/decidim that referenced this pull request May 5, 2020
Merge branch 'develop' into deploy
8ee1c5d 
* develop: (29 commits)
  Update Conversations design with decidim-design UI (decidim#6008)
  Add counter of active users to admin dashboard (decidim#5907)
  Show activity graphs on admin dashboard (decidim#6030)
  Update sassc gem version (decidim#6062)
  Fix generator Gemfile after puma upgrade (decidim#6060)
  New Crowdin translations (decidim#6059)
  Add Slovak as a new language (decidim#6039)
  Remove all tests for i18n PRs (decidim#6061)
  Update move up and down buttons after dragging questions when managing questionnaire (decidim#5947)
  Fix using Decidim as a provider for omniauth authentication (decidim#6042)
  Add redesign for responsive public profile navigation tabs (decidim#6032)
  Add versioning pages to initiatives (decidim#5935)
  Notify users when roles get assigned (decidim#5886)
  Improve the budget page and the project card (decidim#5809)
  New Crowdin translations (decidim#6050)
  New Crowdin translations (decidim#6046)
  Ignore jobs on locales branches (decidim#6047)
  Automatic task for deleting Meeting Inscription data (decidim#5989)
  New Crowdin translations (decidim#5877)
  Ignore builds on Crowdin PRs (decidim#6037)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Leusev Leusev Leusev requested changes

@tramuntanal tramuntanal tramuntanal approved these changes

@agustibr agustibr agustibr left review comments

@leio10 leio10 leio10 left review comments

Assignees

@mrcasals mrcasals

Labels
contract: PAM2020 Barcelona City Council contract in-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add general statistics in the administration panel
5 participants
@mrcasals @tramuntanal @agustibr @leio10 @Leusev