Avoid decidim-core to depend upon other modules #5482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…resenter and cell, but ended up with a refactoring.
oriolgual
approved these changes
Nov 11, 2019
tramuntanal
deleted the
fix/mispelling_in_authorship_related_artifacts
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
This PR has started as a fix for bugfix 35b69c9, but ended up with a refactoring.
So, what is the refactoring about? It is related with the fact that we can not reference artifacts from external modules from core. This is,
decidim-corecan not have dependencies to other modules.So to solve the dependency problem I've implemented an
ActsAsAuthormodule that all authors must include, and this will force them to define apresentermethod which will return the current presenter for the author. This will avoid thedecidim-coremodule to know anything about which is the presenter for each author, except for the official authorships.📌 Related Issues
📋 Subtasks
CHANGELOGentry