Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add d3@v5 tests at the Github CI #1825

Merged
merged 2 commits into from
Apr 6, 2021
Merged

Add d3@v5 tests at the Github CI #1825

merged 2 commits into from
Apr 6, 2021

Conversation

kum-deepak
Copy link
Collaborator

Test cases that checked for d3 formatted -ve numbers were failing. Made these generic.

@kum-deepak kum-deepak mentioned this pull request Apr 5, 2021
Merged
4 tasks
gordonwoodhull
gordonwoodhull approved these changes Apr 6, 2021
View reviewed changes
Copy link
Contributor

@gordonwoodhull gordonwoodhull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! As I recall, it was uglier to test d3@4 and d3@5 simultaneously, so we decided not to test d3@5 when we moved to d3@6.

However, this is quite simple! (except for those silly minus signs)

@gordonwoodhull gordonwoodhull merged commit 4ff6a79 into develop Apr 6, 2021
@kum-deepak
Copy link
Collaborator Author

😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gordonwoodhull gordonwoodhull gordonwoodhull approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kum-deepak @gordonwoodhull