Added some methods and functions to option and result
#172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @dbrattli . Are you accepting PRs to this project? If so and you would be interested in merging this functionality, I can update my branch. If not then I can close the PR. |
dbrattli
reviewed
Oct 26, 2023
expression/core/result.py
Outdated
| @@ -28,6 +28,7 @@ | |||
|
|
|||
| from typing_extensions import TypeAlias, TypeGuard | |||
|
|
|||
| from . import option | |||
There was a problem hiding this comment.
Not happy with option import result and result importing option. Can we use if TYPE_CHECKING: here to avoid getting circular dependencies in the running code?
There was a problem hiding this comment.
I'll take a look
There was a problem hiding this comment.
Thanks for your review. I've updated the PR with your suggestion.
* Convert `Option`s to `Result`s and vice versa * Added `Option#to_optional` for easy convertion to Python's `Optional[T]` * Added a `Result#swap` method * Added tests for all of the above Also: * Fixed some documentation for `Result#default_values` and `Result#default_with`
brendanmaguire
force-pushed
the
new-option-and-result-methods
branch
from
fd39da5 to
b6f2fea
Compare
dbrattli
approved these changes
Nov 2, 2023
Thank you for the great library 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Options toResults and vice versaOption#to_optionalfor easy convertion to Python'sOptional[T]Result#swapmethodAlso:
Result#default_valuesandResult#default_with