Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix map's change (issue 105) #106

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Conversation

matiboy
Copy link

@matiboy matiboy commented Jan 11, 2023

Add simple test for change

mat added 2 commits January 11, 2023 07:07
@matiboy
Copy link
Author

matiboy commented Jan 11, 2023

Tinkering with this PR and tests made me realize what I think is another issue:

m1 = Map.empty().add('a',1)
m2 = Map.empty().add('a',1).add('b',2)

m1 == m2 # True
m2 == m1 # False

@dbrattli
Copy link
Owner

dbrattli commented Feb 4, 2023

Hi @matiboy. I didn't see your PR before I fixed the change bug. But it looks like you have found another bug as well. Anyways, I would like to keep your tests from this PR. Then we should investigate the other issue you found.

@matiboy
Copy link
Author

matiboy commented Feb 4, 2023

Hi @matiboy. I didn't see your PR before I fixed the change bug. But it looks like you have found another bug as well. Anyways, I would like to keep your tests from this PR. Then we should investigate the other issue you found.

Hi @dbrattli Sure please feel free to copy the test into main/your own branch and close this PR, no issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants