refactor(mistral): update safe_mode property and max temperature in ChatCompletionRequest #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kndpt
changed the title
davidmigloz
requested changes
Jan 18, 2024
There was a problem hiding this comment.
Thanks again for the PR!
I've added a couple of comments. Basically:
- The generated files have been generated in the wrong folder
- We don't need to update the version / release notes manually
The changes in the OpenAPI spec look good, so as soon as we fix those couple of things we can merge it 🙂
kndpt
force-pushed
the
refactor/mistral-prompt
branch
from
d4cf13f to
2ffe1d4
Compare
…hatCompletionRequest
kndpt
force-pushed
the
refactor/mistral-prompt
branch
from
2ffe1d4 to
ad2b0c2
Compare
davidmigloz
approved these changes
Jan 19, 2024
davidmigloz
added
c:chat-models
KennethKnudsen97
pushed a commit
to KennethKnudsen97/langchain_dart
that referenced
this pull request
Apr 22, 2024
…migloz#300) - `safe_mode` was renamed to `safe_prompt` - The max temperature is now 1 instead of 2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The request body schema for Chat Completion changed.
@davidmigloz
I have a big doubt about the "refactor" I chose for the PR. Because it's not a bug. More of a small breaking change.