Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4 scripts to ingest all required data #5

Merged
merged 34 commits into from
Jan 30, 2024

Conversation

Edward-Jackson-ONS
Copy link
Collaborator

Closes #4, #3

Description

Fixes #(issue_number)

Motivation and Context

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

One test unit for StaticDataIngest. Other tests to follow once CodeCov trigger rectified.

Test configuration details:

  • OS: MacOS
  • Python version: 3.11.7
  • Java version:
  • Python management system:

Advice for reviewer

Ingest scripts for all NAPTAN, geography and timetable data
Ingest scripts for 1 minute sample of BODS realtime data
Updated README
Various bug fixes/updates
Single unit test
CodeCov pending...

Checklist:

  • My code follows the intended structure of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Additional comments

@Edward-Jackson-ONS Edward-Jackson-ONS added the enhancement New feature or request label Jan 24, 2024
@Edward-Jackson-ONS Edward-Jackson-ONS linked an issue Jan 24, 2024 that may be closed by this pull request
4 tasks
Copy link

codecov bot commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (dev@b8cfca1). Click here to learn what that means.

Additional details and impacted files
@@          Coverage Diff           @@
##             dev       #5   +/-   ##
======================================
  Coverage       ?   56.09%           
======================================
  Files          ?        2           
  Lines          ?      123           
  Branches       ?        0           
======================================
  Hits           ?       69           
  Misses         ?       54           
  Partials       ?        0           
Flag Coverage Δ
unittests 56.09% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@r-leyshon
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (dev@b8cfca1). Click here to learn what that means.

Additional details and impacted files
☔ View full report in Codecov by Sentry. 📢 Have feedback on the report? Share it here.

Heads up @daniel-coles-ons - you see this message the first time you configure codecov. It attempts to give you a coverage update report (eg x more lines covered since this branch diverged from main). It has nothing to compare to the first time it runs, but from thereon you will get coverage deltas appearing in the comments from codecov bot.

@daniel-coles-ons daniel-coles-ons merged commit 6ef26c2 into dev Jan 30, 2024
4 checks passed
@Edward-Jackson-ONS Edward-Jackson-ONS deleted the 4-scripts-to-ingest-all-required-data branch February 6, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scripts to ingest all required data
3 participants